Figured it might be better as a seperate topic, if we need to bikeshed about it
As I said in the PR, I’m debating making it error on all warnings as well. If we believe it’s not an issue it’s pretty easy to add an
#[allow(clippy::...)], and fixing lints just improves the quality of the code base.
It does add nice annotations like this:
But I’m not sure that’s enough, you need to go through all the changes to see this issue. I try and do that all the time but it’s still pretty easy to miss a lint. On the other hand, it can be pretty annoying if you’ve put a lot of work into a PR and then you have to deal with clippy.